Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: movead.li@highgo.ca
Cc: andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@postgresql.org, ahsan.hadi@highgo.ca
Date: 2020-10-15T08:38:09Z
Lists: pgsql-hackers
At Thu, 15 Oct 2020 17:32:10 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> At Thu, 15 Oct 2020 12:56:02 +0800, "movead.li@highgo.ca" <movead.li@highgo.ca> wrote in 
> > Thanks for all the suggestions.
> > 
> > >Yeah.  In its current shape, it means that only pg_waldump would be
> > >able to know this information.  If you make this information part of
> > >xlogdesc.c, any consumer of the WAL record descriptions would be able
> > >to show this information, so it would provide a consistent output for
> > >any kind of tools.
> > I have change the implement, move some code into xlog_desc().
> 
> Andres suggested that we don't need that description with per-record
> basis. Do you have a reason to do that?  (For clarity, I'm not
> suggesting that you should reving it.)

Sorry. Maybe I deleted wrong letters in the "reving" above.

====
Andres suggested that we don't need that description with per-record
basis. Do you have a reason to do that?  (For clarity, I'm not
suggesting that you should remove it.)
====

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



Commits

  1. pg_waldump: Fix bug in per-record statistics.