Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, movead.li@highgo.ca, pgsql-hackers@postgresql.org, ahsan.hadi@highgo.ca
Date: 2020-10-14T20:46:13Z
Lists: pgsql-hackers
Hi, On 2020-10-14 15:52:43 +0900, Michael Paquier wrote: > Yeah. In its current shape, it means that only pg_waldump would be > able to know this information. If you make this information part of > xlogdesc.c, any consumer of the WAL record descriptions would be able > to show this information, so it would provide a consistent output for > any kind of tools. I'm not convinced by this argument. The only case where accounting for the "wasted" length seems really interesting is for --stats=record - and for that including it in the record description is useless. When looking at plain records the length is sufficiently deducable by looking at the next record's LSN. Greetings, Andres Freund
Commits
-
pg_waldump: Fix bug in per-record statistics.
- e73068b0710b 9.6.22 landed
- 5386a8506d7d 10.17 landed
- 4a2627c41cfe 11.12 landed
- 4220e06f4c0c 12.7 landed
- 34279fd4fabd 13.3 landed
- 51893c846350 14.0 landed