Re: BUG #16666: Slight memory leak when running pg_ctl reload

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>
To: bchen90@163.com, pgsql-bugs@lists.postgresql.org
Date: 2020-10-12T14:19:38Z
Lists: pgsql-bugs
On Mon, Oct 12, 2020 at 01:32:13PM +0000, PG Bug reporting form wrote:
> The following bug has been logged on the website:
> 
> Bug reference:      16666
> Logged by:          BoChen
> Email address:      bchen90@163.com
> PostgreSQL version: 11.8
> Operating system:   SUSE Linux Enterprise Server 11 (x86_64)
> Description:        
> 
> I found slighting memory leakage occured when running pg_ctl reload command
> for the following code segment(guc.c:6726-6740). When runing 'pg_ctl
> reload', for these string type PGC_POSTMASTER GUC variables like
> 'unix_socket_directories', the following code segment will leak newval's
> memery.

Uh, you are saying pg_ctl leaks memory or the database server leaks
memory?  I don't see any memory allocation in the code you posted.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee




Commits

  1. Fix memory leak when guc.c decides a setting can't be applied now.