Horton

Wrong statistics for size of XLOG_SWITCH during pg_waldump.

movead.li@highgo.ca <movead.li@highgo.ca>

View thread View on postgr.es
From: "movead.li@highgo.ca" <movead.li@highgo.ca>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: ahsan.hadi <ahsan.hadi@highgo.ca>
Date: 2020-10-09T05:41:25Z
Lists: pgsql-hackers

Attachments

Hello hackers,

We know that pg_waldump can statistics size for every kind of records. When I use
the feature I find it misses some size for XLOG_SWITCH records. When a user does
a pg_wal_switch(), then postgres will discard the remaining size in the current wal
segment, and the pg_waldump tool misses the discard size.

I think it will be better if pg_waldump  can show the matter, so I make a patch
which regards the discard size as a part of XLOG_SWITCH record, it works if we
want to display the detail of wal records or the statistics, and patch attached.

What's your opinion?



Regards,
Highgo Software (Canada/China/Pakistan) 
URL : www.highgo.ca 
EMAIL: mailto:movead(dot)li(at)highgo(dot)ca

Commits

  1. pg_waldump: Fix bug in per-record statistics.