Re: A modest proposal: let's add PID to assertion failure messages

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-10-05T00:58:24Z
Lists: pgsql-hackers
On Mon, Oct 05, 2020 at 10:20:01AM +1300, Thomas Munro wrote:
> On Mon, Oct 5, 2020 at 10:08 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> In these days when we run almost all test cases in parallel, it's
>> frequently not that easy to tie a "TRAP: ..." message in the log
>> to nearby log messages.  (The postmaster's subsequent complaint
>> often helps, but it could be some distance away in the log; and
>> good luck untangling things if more than one Assert failure happens
>> concurrently.)  We could add a simple bread crumb trail by
>> including the process's PID in such messages.  Any objections?
> 
> +1

+1.  (log_line_prefix includes %p in its default configuration for the
TAP tests).
--
Michael

Commits

  1. Include the process PID in assertion-failure messages.