Horton

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Alexey Kondratov <a.kondratov@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Kuntal Ghosh <kuntalghosh.2007@gmail.com>, Liudmila Mantrova <l.mantrova@postgrespro.ru>, Thomas Munro <thomas.munro@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, David Steele <david@pgmasters.net>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru
Date: 2020-03-31T06:48:21Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move frontend-side archive APIs from src/common/ to src/fe_utils/

  2. Add -c/--restore-target-wal to pg_rewind

  3. Move routine definitions of xlogarchive.c to a new header file

  4. Move routine building restore_command to src/common/

  5. Integrate recovery.conf into postgresql.conf

On Mon, Mar 30, 2020 at 05:00:01PM +0300, Alexey Kondratov wrote:
> What do think about adding following sanity check into xlogarchive.c?
> 
> +#ifdef FRONTEND
> +#error "This file is not expected to be compiled for frontend code"
> +#endif
> 
> It would prevent someone from adding typedefs and any other common
> definitions into xlogarchive.h in the future, leading to the accidental
> inclusion of both xlogarchive.h and fe_archive.h in the same time.

I don't see much the point as this would fail to compile anyway, and
that's not project-style.  Note that we have already a clear
separation here between the backend and the frontend code here as
xlogarchive.h is backend-only and fe_archive.h is frontend-only.

> 0002:
>
> [format comments]
>
> Let us use camel case 'restoreCommand' here as in the header for tidiness.

All this makes sense, and also note the same formatting issue in
parsexlog.c for RestoreArchivedFile().  A run of pgindent was
missing.

> I have left 0001 intact, but fixed all these small remarks in the 0002.
> Please, find it attached.

Thanks, committed 0001 after fixing the order of the headers.  One
patch left.
--
Michael