Horton

Re: backup manifests

Bruce Momjian <bruce@momjian.us>

View thread
From: Bruce Momjian <bruce@momjian.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, David Steele <david@pgmasters.net>, Jeevan Chalke <jeevan.chalke@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, Rushabh Lathia <rushabh.lathia@gmail.com>, Suraj Kharage <suraj.kharage@enterprisedb.com>, Tels <nospam-pg-abuse@bloodgate.com>, tushar <tushar.ahuja@enterprisedb.com>, vignesh C <vignesh21@gmail.com>
Date: 2020-03-27T22:39:46Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Try to avoid compiler warnings in optimized builds.

  2. Fix option related issues in pg_verifybackup.

  3. Add index term for backup manifest in documentation.

  4. Code review for backup manifest.

  5. Document the backup manifest file format.

  6. Fix typo in pg_validatebackup documentation.

  7. Exclude backup_manifest file that existed in database, from BASE_BACKUP.

  8. Msys2 tweaks for pg_validatebackup corruption test

  9. Fix resource management bug with replication=database.

  10. Be more careful about time_t vs. pg_time_t in basebackup.c.

  11. pg_validatebackup: Fix 'make clean' to remove tmp_check.

  12. pg_validatebackup: Also use perl2host in TAP tests.

  13. Generate backup manifests for base backups, and validate them.

  14. Add checksum helper functions.

  15. pg_waldump: Add a --quiet option.

  16. Catversion bump for b9b408c48724

  17. pg_basebackup: Refactor code for reading COPY and tar data.

  18. Use a ResourceOwner to track buffer pins in all cases.

  19. Use ARMv8 CRC instructions where available.

  20. Logical replication support for initial data copy

  21. Use Intel SSE 4.2 CRC instructions where available.

  22. Switch to CRC-32C in WAL and other places.

  23. Remove support for 64-bit CRC.

  24. Change CRCs in WAL records from 64bit to 32bit for performance reasons.

On Fri, Mar 27, 2020 at 06:38:33PM -0400, Stephen Frost wrote:
> Greetings,
> 
> On Fri, Mar 27, 2020 at 18:36 Bruce Momjian <bruce@momjian.us> wrote:
> 
>     On Thu, Mar 26, 2020 at 12:34:52PM -0400, Stephen Frost wrote:
>     > * Robert Haas (robertmhaas@gmail.com) wrote:
>     > > This is where I feel like I'm trying to make decisions in a vacuum. If
>     > > we had a few more people weighing in on the thread on this point, I'd
>     > > be happy to go with whatever the consensus was. If most people think
>     > > having both --no-manifest (suppressing the manifest completely) and
>     > > --manifest-checksums=none (suppressing only the checksums) is useless
>     > > and confusing, then sure, let's rip the latter one out. If most people
>     > > like the flexibility, let's keep it: it's already implemented and
>     > > tested. But I hate to base the decision on what one or two people
>     > > think.
>     >
>     > I'm frustrated at the lack of involvement from others also.
> 
>     Well, the topic of backup manifests feels like it has generated a lot of
>     bickering emails, and people don't want to spend their time dealing with
>     that.
> 
> 
> I’d like to not also.  I suppose it’s just an area that I’m particularly
> concerned with that allows me to overcome that. Backups are important to me.

The big question is whether the discussion _needs_ to be that way.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +