Horton

Re: backup manifests

Stephen Frost <sfrost@snowman.net>

View thread
From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David Steele <david@pgmasters.net>, Amit Kapila <amit.kapila16@gmail.com>, Suraj Kharage <suraj.kharage@enterprisedb.com>, tushar <tushar.ahuja@enterprisedb.com>, Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, Rushabh Lathia <rushabh.lathia@gmail.com>, Tels <nospam-pg-abuse@bloodgate.com>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Jeevan Chalke <jeevan.chalke@enterprisedb.com>, vignesh C <vignesh21@gmail.com>
Date: 2020-03-27T19:48:50Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Try to avoid compiler warnings in optimized builds.

  2. Fix option related issues in pg_verifybackup.

  3. Add index term for backup manifest in documentation.

  4. Code review for backup manifest.

  5. Document the backup manifest file format.

  6. Fix typo in pg_validatebackup documentation.

  7. Exclude backup_manifest file that existed in database, from BASE_BACKUP.

  8. Msys2 tweaks for pg_validatebackup corruption test

  9. Fix resource management bug with replication=database.

  10. Be more careful about time_t vs. pg_time_t in basebackup.c.

  11. pg_validatebackup: Fix 'make clean' to remove tmp_check.

  12. pg_validatebackup: Also use perl2host in TAP tests.

  13. Generate backup manifests for base backups, and validate them.

  14. Add checksum helper functions.

  15. pg_waldump: Add a --quiet option.

  16. Catversion bump for b9b408c48724

  17. pg_basebackup: Refactor code for reading COPY and tar data.

  18. Use a ResourceOwner to track buffer pins in all cases.

  19. Use ARMv8 CRC instructions where available.

  20. Logical replication support for initial data copy

  21. Use Intel SSE 4.2 CRC instructions where available.

  22. Switch to CRC-32C in WAL and other places.

  23. Remove support for 64-bit CRC.

  24. Change CRCs in WAL records from 64bit to 32bit for performance reasons.

Greetings,

* Robert Haas (robertmhaas@gmail.com) wrote:
> On Thu, Mar 26, 2020 at 4:37 PM David Steele <david@pgmasters.net> wrote:
> > I agree with Stephen that this should be done, but I agree with you that
> > it can wait for a future commit. However, I do think:
> >
> > 1) It should be called out rather plainly in the documentation.
> > 2) If there are files in pg_wal then pg_validatebackup should inform the
> > user that those files have not been validated.
> 
> I agree with you about #1, and I suspect that there's a way to improve
> what I've got here now, but I think I might be too close to this to
> figure out what the best way would be, so suggestions welcome.
> 
> I think #2 is an interesting idea and could possibly reduce the danger
> of user confusion on this point considerably - because, let's face it,
> not everyone is going to read the documentation. However, I'm having a
> hard time figuring out exactly what we'd print. Right now on success,
> unless you specify -q, you get:
> 
> [rhaas ~]$ pg_validatebackup  ~/pgslave
> backup successfully verified
> 
> But it feels strange and possibly confusing to me to print something like:
> 
> [rhaas ~]$ pg_validatebackup  ~/pgslave
> backup successfully verified (except for pg_wal)
> 
> ...because there are a few other exceptions too, and also because it

The exceptions you're referring to here are things like the various
signal files, that the user can recreated pretty easily..?  I don't
think those really rise to the level of pg_wal.

What I would hope to see (... well, we know what I *really* would hope
to see, but if we really go this route) is something like:

WARNING: pg_wal not empty, WAL files are not validated by this tool
data files successfully verified

and a non-zero exit code.

Basically, if you're doing WAL yourself, then you'd use pg_receivewal
and maybe your own manifest-building code for WAL or something and then
use -X none with pg_basebackup.

Then again, I'd have -X none throw a warning too.  I'd be alright with
all of these having override switches to say "ok, I get it, don't
complain about it".

I disagree with the idea of writing "backup successfully verified" when
we aren't doing any checking of the WAL that's essential for the backup
(unlike various signal files and whatnot, which aren't...).

Thanks,

Stephen