Re: pgsql: Add kqueue(2) support to the WaitEventSet API.
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>, Thomas Munro <tmunro@postgresql.org>, pgsql-committers <pgsql-committers@lists.postgresql.org>
Date: 2020-03-16T20:30:40Z
Lists: pgsql-hackers
On 2020-Mar-17, Thomas Munro wrote: > Reproduced here. The problem seems to be that macOS's getppid() > returns the debugger's PID, while the debugger is attached. This > doesn't happen on FreeBSD (even though the debugger does internally > become the parent, getppid() is careful to return the "real" parent > PID so that user space doesn't notice this trickery; apparently Apple > made a different choice). Wow ... Yeah, that was a known problem with FreeBSD, see https://postgr.es/m/1292851036-sup-5399@alvh.no-ip.org Evidently FreeBSD must have fixed it, but macOS has not caught up with that ... > The getppid() check is there to close a vanishingly rare race > condition: when creating a WaitEventSet, we ask the kernel to tell us > when the postmaster exits, but there is a possibility that the > postmaster has already exited; normally that causes an error with > errno == ESRCH (no such PID, it's already gone), but another unrelated > process might have started that has the same PID, so we check if our > ppid has changed after a successful return code. That's not going to > work under a debugger on this OS. Irk. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Don't use EV_CLEAR for kqueue events.
- 9b8aa0929390 13.0 cited
-
Fix kqueue support under debugger on macOS.
- 7bc84a1f304a 13.0 landed
-
Account explicitly for long-lived FDs that are allocated outside fd.c.
- 3d475515a15f 13.0 landed
-
Add kqueue(2) support to the WaitEventSet API.
- 815c2f0972c8 13.0 cited
-
Introduce WaitEventSet API.
- 98a64d0bd713 9.6.0 cited