Re: backend type in log_line_prefix?

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>

To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2020-03-10T18:07:31Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add backend type to csvlog and optionally log_line_prefix
- 70a7b4776be4 13.0 landed
Remove am_syslogger global variable
- d90bd24391fd 13.0 landed
Unify several ways to tracking backend type
- 8e8a0becb335 13.0 landed
Refactor ps_status.c API
- bf68b79e50e3 13.0 landed
Add background worker type
- 5373bc2a0867 11.0 cited

I like these patches; the first two are nice cleanup.

My only gripe is that pgstat_get_backend_desc() is not really a pgstat
function; I think it should have a different name with a prototype in
miscadmin.h (next to the enum's new location, which I would put
someplace near the "pmod.h" comment rather than where you put it;
perhaps just above the AuxProcType definition), and implementation
probably in miscinit.c.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services