Re: Add an optional timeout clause to isolationtester step.
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Julien Rouhaud <rjuju123@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-03-10T02:55:36Z
Lists: pgsql-hackers
On Mon, Mar 09, 2020 at 10:32:27PM -0400, Tom Lane wrote: > It strikes me to wonder whether we could improve matters by teaching > isolationtester to watch for particular values in a connected backend's > pg_stat_activity.wait_event_type/wait_event columns. Those columns > didn't exist when isolationtester was designed, IIRC, so it's not > surprising that they're not used in the current design. But we could > use them perhaps to detect that a backend has arrived at some state > that's not a heavyweight-lock-wait state. Interesting idea. So that would be basically an equivalent of PostgresNode::poll_query_until but for the isolation tester? In short we gain a meta-command that runs a SELECT query that waits until the query defined in the command returns true. The polling interval may be tricky to set though. If set too low it would consume resources for nothing, and if set too large it would make the tests using this meta-command slower than they actually need to be. Perhaps something like 100ms may be fine.. -- Michael
Commits
-
Prevent reindex of invalid indexes on TOAST tables
- 8bca5f93547c 12.3 landed
- 61d7c7bce368 13.0 landed
-
Fix more issues with dependency handling at swap phase of REINDEX CONCURRENTLY
- 26876127be2c 12.3 landed
- fbcf0871123b 13.0 landed