Horton

Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side

Jehan-Guillaume de Rorthais <jgdr@dalibo.com>

View thread View on postgr.es
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, Magnus Hagander <magnus@hagander.net>, "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi.shinoda@hpe.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, "amitlangote09@gmail.com" <amitlangote09@gmail.com>, "masahiko.sawada@2ndquadrant.com" <masahiko.sawada@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-03-05T09:41:02Z
Lists: pgsql-hackers 
On Thu, 5 Mar 2020 10:32:45 +0100
Julien Rouhaud <rjuju123@gmail.com> wrote:

> On Thu, Mar 5, 2020 at 8:15 AM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
> >
> > On 2020-03-05 05:53, Fujii Masao wrote:  
> > > Or, as another approach, it might be worth considering to make
> > > the server always estimate the total backup size whether --progress is
> > > specified or not, as Amit argued upthread. If the time required to
> > > estimate the backup size is negligible compared to total backup time,
> > > IMO this approach seems better. If we adopt this, we can also get
> > > rid of PROGESS option from BASE_BACKUP replication command.  
> >
> > I think that would be preferable.  
> 
> +1

+1

Commits

  1. Report NULL as total backup size if it's not estimated.

  2. Make pg_basebackup ask the server to estimate the total backup size, by default.

  3. Report progress of streaming base backup.