Re: reindex concurrently and two toast indexes
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Sergei Kornilov <sk@zsrv.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Michael Paquier <michael.paquier@gmail.com>, Andreas Karlsson <andreas@proxel.se>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-03-03T09:25:51Z
Lists: pgsql-hackers
Attachments
- reindex-deps-v2.patch (text/x-diff) patch v2
On Tue, Mar 03, 2020 at 05:06:42PM +0900, Michael Paquier wrote: > Attached is a draft patch to take care of that problem for HEAD. It > still needs a lot of polishing (variable names are not actually old > or new anymore, etc.) but that's enough to show the idea. If a version > reaches PG12, we would need to keep around the past routines to avoid > an ABI breakage, even if I doubt there are callers of it, but who > knows.. Or actually, a more simple solution is to abuse of the two existing routines so as the dependency switch is done the other way around, from the new index to the old one. That would visibly work because there is no CCI between each scan, and that's faster because the scan of pg_depend is done only on the entries in need of an update. I'll look at that again tomorrow, it is late here and I may be missing something obvious. -- Michael
Commits
-
Prevent reindex of invalid indexes on TOAST tables
- 8bca5f93547c 12.3 landed
- 61d7c7bce368 13.0 landed
-
Fix more issues with dependency handling at swap phase of REINDEX CONCURRENTLY
- 26876127be2c 12.3 landed
- fbcf0871123b 13.0 landed