Horton

Re: Portal->commandTag as an enum

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, John Naylor <john.naylor@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-03-02T16:33:57Z
Lists: pgsql-hackers 
On 2020-Mar-02, Mark Dilger wrote:

> > I don't
> > understand your point of pg_stats_sql having to deal with this in a
> > particular way.  How is that patch obtaining the command tags?  I would
> > hope it calls GetCommandTagName() rather than call CommandEnd, but maybe
> > I misunderstand where it hooks.
> 
> My objection was based on my misunderstanding of what Tom was requesting.
> 
> I can rework the patch the way Tom suggests.

I already did it :-)  Posting in a jiffy

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Update comment

  2. Represent command completion tags as structs