Horton

Re: Portal->commandTag as an enum

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: John Naylor <john.naylor@2ndquadrant.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-02-28T20:54:16Z
Lists: pgsql-hackers 
On 2020-Feb-21, John Naylor wrote:

> Thinking about this some more, would it be possible to treat these
> like we do parser/kwlist.h? Something like this:
> 
> commandtag_list.h:
> PG_COMMANDTAG(ALTER_ACCESS_METHOD, "ALTER ACCESS METHOD", true, false,
> false, false)
> ...

I liked this idea, so I'm halfway on it now.

> I'm hand-waving a bit, and it doesn't have the flexibility of a .dat
> file, but it's a whole lot simpler.

Yeah, I for one don't want to maintain the proposed DataFile.pm.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Update comment

  2. Represent command completion tags as structs