Re: pg_trigger.tgparentid

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2020-02-25T14:00:55Z
Lists: pgsql-hackers
On 2020-Feb-25, Amit Langote wrote:

> On Tue, Feb 25, 2020 at 3:58 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> > Thanks for pointing this out -- I agree it needed rewording.  I slightly
> > adjusted your text like this:
> >
> >                  * Internal triggers require careful examination.  Ideally, we don't
> >                  * clone them.  However, if our parent is itself a partition, there
> >                  * might be internal triggers that must not be skipped; for example,
> >                  * triggers on our parent that are in turn clones from its parent (our
> >                  * grandparent) are marked internal, yet they are to be cloned.
> >
> > Is this okay for you?
> 
> Thanks.  Your revised text looks good, except there is a typo:
> 
> in turn clones -> in turn cloned

Actually, that was on purpose ...  (I also changed "were" to "are" to match.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Commits

  1. Record parents of triggers

  2. Fix docs regarding AFTER triggers on partitioned tables