Horton

Re: Clean up some old cruft related to Windows

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-02-18T06:54:18Z
Lists: pgsql-hackers 
On Thu, Dec 19, 2019 at 08:09:45PM +0100, Juan José Santamaría Flecha wrote:
> This is probably not an issue for the supported MSVC and their SDK, but
> current MinGW defaults to Windows 2003 [1]. So I would suggest a logic like:
> 
> #define WINNTVER(ver) ((ver) >> 16)
> #define NTDDI_VERSION 0x06000100
> #define _WIN32_WINNT WINNTVER(NTDDI_VERSION)
> 
> [1]
> https://github.com/mirror/mingw-w64/blob/master/mingw-w64-headers/include/sdkddkver.h

You're right, thanks for the pointer.  This is this part of the
header:
#define NTDDI_VERSION NTDDI_WS03

Thinking more about that, the changes in win32.h are giving me cold
feet.
--
Michael

Commits

  1. Doc: Fix instructions to control build environment with MSVC

  2. Clean up some code, comments and docs referring to Windows 2000 and older