Re: allow frontend use of the backend's core hashing functions
David Fetter <david@fetter.org>
From: David Fetter <david@fetter.org>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Suraj Kharage <suraj.kharage@enterprisedb.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-02-14T16:29:01Z
Lists: pgsql-hackers
On Fri, Feb 14, 2020 at 08:16:47AM -0800, Mark Dilger wrote: > > On Feb 14, 2020, at 8:15 AM, David Fetter <david@fetter.org> wrote: > > > > On Fri, Feb 14, 2020 at 10:33:04AM -0500, Robert Haas wrote: > >> On Thu, Feb 13, 2020 at 11:26 AM Mark Dilger > >> <mark.dilger@enterprisedb.com> wrote: > >>> I have made these changes and rebased Robert’s patches but > >>> otherwise changed nothing. Here they are: > >> > >> Thanks. Anyone else have comments? I think this is pretty > >> straightforward and unobjectionable work so I'm inclined to press > >> forward with committing it fairly soon, but if someone feels > >> otherwise, please speak up. > > > > One question. It might be possible to make these functions faster > > using compiler intrinsics. Would those still be available to front-end > > code? > > Do you have a specific proposal that would preserve on-disk compatibility? I hadn't planned on changing the representation, just cutting instructions out of the calculation of same. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
Commits
-
Move src/backend/utils/hash/hashfn.c to src/common
- 05d8449e7369 13.0 landed
-
Adapt hashfn.c and hashutils.h for frontend use.
- a91e2fa94180 13.0 landed
-
Put all the prototypes for hashfn.c into the same header file.
- 9341c783cc42 13.0 landed
-
Move bitmap_hash and bitmap_match to bitmapset.c.
- 07b95c3d8334 13.0 landed