Horton

Re: In PG12, query with float calculations is slower than PG11

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Emre Hasegeli <emre@hasegeli.com>, nospam-pg-abuse@bloodgate.com, Amit Langote <amitlangote09@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, keisuke kuroda <keisuke.kuroda.3862@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-02-13T18:47:10Z
Lists: pgsql-hackers 
Hi,

On 2020-02-13 13:40:43 -0500, Tom Lane wrote:
> ... and pushed.  One other change I made beyond those suggested
> was to push the zero-divide ereport's out-of-line as well.

Thanks!


> I did not do anything about adding unlikely() calls around the
> unrelated isinf tests in float.c.  That seemed to me to be a separate
> matter, and I'm not quite convinced it'd be a win anyway.

I was mostly going for consistency...

Greetings,

Andres Freund

Commits

  1. Avoid a performance regression in float overflow/underflow detection.

  2. Provide separate header file for built-in float types