Horton

Re: Getting rid of some more lseek() calls

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-02-12T16:30:25Z
Lists: pgsql-hackers 
On 2020-Feb-12, Thomas Munro wrote:

> Hmm.  Well, on Unix we have to choose between "tell me the size but
> also change the position that I either don't care about or have to
> undo", and "tell me the size but also tell me all this other stuff I
> don't care about".  Since Windows apparently has GetFileSizeEx(), why
> not use that when that's exactly what you want?  It apparently
> understands large files.

I was already thinking that it might be better to make the new function
just "tell me the file size" without leaking the details of *how* we do
it, before reading about this Windows call.  That reinforces it, IMO.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Use pg_pread() and pg_pwrite() in slru.c.

  2. Use pg_pwrite() in more places.