Re: Portal->commandTag as an enum

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-02-11T21:02:46Z
Lists: pgsql-hackers
On 2020-Feb-11, Mark Dilger wrote:

> > No thanks.
> 
> I’m not sure which option you are voting for:
> 
> (Option #1) Have the perl script generate the .c and .h file from a .dat file
> 
> (Option #2) Have the perl script validate but not generate the .c and .h files
> 
> (Option #3) Have no perl script, with all burden on the programmer to get the .c and .h files right by hand.
> 
> I think you’re voting against #3, and I’m guessing you’re voting for #1, but I’m not certain.

I was voting against #2 (burden the programmer with consistency checks
that must be fixed by hand, without actually doing the programmatically-
doable work), but I don't like #3 either.  I do like #1.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Commits

  1. Update comment

  2. Represent command completion tags as structs