Re: Portal->commandTag as an enum

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-02-11T20:50:47Z
Lists: pgsql-hackers
On 2020-Feb-11, Mark Dilger wrote:

> I thought about generating the files rather than merely checking them.
> I could see arguments both ways.  I wasn’t sure whether there would be
> broad support for having yet another perl script generating source
> files, nor for the maintenance burden of having to do that on all
> platforms.  Having a perl script that merely sanity checks the source
> files has the advantage that there is no requirement for it to
> function on all platforms.  There’s not even a requirement for it to
> be committed to the tree, since you could also argue that the
> maintenance burden of the script outweighs the burden of getting the
> source files right by hand.

No thanks.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Commits

  1. Update comment

  2. Represent command completion tags as structs