Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: amitlangote09@gmail.com
Cc: masao.fujii@oss.nttdata.com, masahiko.sawada@2ndquadrant.com,
pgsql-hackers@postgresql.org
Date: 2020-02-06T00:50:27Z
Lists: pgsql-hackers
At Wed, 5 Feb 2020 18:53:19 +0900, Amit Langote <amitlangote09@gmail.com> wrote in > Last two messages weren’t sent to the list. Oops! Sorry, I made a mistake sending the mail. > On Wed, Feb 5, 2020 at 18:25 Amit Langote <amitlangote09@gmail.com> wrote: > > > On Wed, Feb 5, 2020 at 6:15 PM Kyotaro Horiguchi > > <horikyota.ntt@gmail.com> wrote: > > > 2020年2月5日(水) 17:54 Amit Langote <amitlangote09@gmail.com>: > > >> > > So, maybe you're saying that "waiting for checkpoint" is ambiguous and > > most people will assume it means "...to start". As for me, I assume > > it ends with "...to finish". I'm not sure "most peple will assume" or not, so I said "I'm not sure". For example, I feel strangeness to use "I'm waiting for Amit" to express that I'm waiting Amit to leave there. That phrase gives me such kind of uneasiness. I thought of "establishing checkpoint" or "running a checkpoint" as other candidates. > > >> As Fujii-san says > > >> though we don't need the noise words "to finish". > > > > > > Understood, sorry for my noise. > > > > Actually, that's an important point to consider and we should strive > > to use words that are unambiguous. I think it's not ambiguous if knowing what happens during backup so my concern was not unambiguity, but that it might give feeling of strangeness that that sentense appears in that context. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
Commits
-
Report NULL as total backup size if it's not estimated.
- 67e0adfb3f98 13.0 landed
-
Make pg_basebackup ask the server to estimate the total backup size, by default.
- fab13dc50ba5 13.0 landed
-
Report progress of streaming base backup.
- e65497df8f85 13.0 landed