Re: BUG #16171: Potential malformed JSON in explain output
hubert depesz lubaczewski <depesz@depesz.com>
From: hubert depesz lubaczewski <depesz@depesz.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Hamid Akhtar <hamid.akhtar@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2020-02-03T11:40:22Z
Lists: pgsql-bugs, pgsql-hackers
On Sun, Feb 02, 2020 at 11:48:32AM -0500, Tom Lane wrote: > > Does that prevent backpatching this, or are we Ok with EXPLAIN text output not > > being stable across minors? AFAICT Pg::Explain still works fine with this > > change, but mileage may vary for other parsers. > I'm not sure about that either. It should be a clear win for parsers > of the non-text formats, because now we're generating valid > JSON-or-whatever where we were not before. But it's not too hard to > imagine that someone's ad-hoc parser of text output would break, > depending on how much it relies on field order rather than indentation > to make sense of things. Change looks reasonable to me. Interestingly Pg::Explain doesn't handle either current JSON output in this case (as it's not a valid JSON), nor the new one - but this can be fixed easily. Best regards, depesz
Commits
-
Fix handling of "Subplans Removed" field in EXPLAIN output.
- 9a85860e12aa 12.2 landed
- 842a23efa92a 11.7 landed
- 7d91b604d9b5 13.0 landed
-
Doc: Fix list of storage parameters available for ALTER TABLE
- c4c76d198e3d 12.2 cited