Horton

Re: Greatest Common Divisor

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Vik Fearing <vik.fearing@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Fabien COELHO <coelho@cri.ensmp.fr>, Stephen Frost <sfrost@snowman.net>, Chapman Flack <chap@anastigmatix.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-01-20T19:04:14Z
Lists: pgsql-hackers 
On 2020-Jan-20, Dean Rasheed wrote:

> +       <entry>
> +        greatest common divisor &mdash; the largest positive number that
> +        divides both inputs with no remainder; returns <literal>0</literal> if
> +        both inputs are zero
> +       </entry>

Warning, severe TOC/bikeshedding ahead.

I don't know why, but this dash-semicolon sequence reads strange to me
and looks out of place.  I would use parens for the first phrase and
keep the semicolon, that is "greatest common divisor (the largest ...);
returns 0 if ..."

That seems more natural to me, and we're already using parens in other
description <entry>s.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Add functions gcd() and lcm() for integer and numeric types.