Re: pgbench - use pg logging capabilities
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-01-09T04:02:48Z
Lists: pgsql-hackers
Attachments
- pgbench-logs.patch (text/x-diff) patch
On Wed, Jan 08, 2020 at 03:31:46PM +0100, Peter Eisentraut wrote: > On 2020-01-08 15:12, Michael Paquier wrote: >> while syntax_error() has been >> changed in a more modular way. > > I don't follow what you mean by that. The first versions of the patch did not change syntax_error(), and the version committed has switched to use PQExpBufferData there. I think that we should just do the same for the debug logs executing the meta commands. This way, we get an output consistent with what's printed out for sending or receiving stuff. Please see the attached. -- Michael
Commits
-
pgbench: Make more debug messages use common logging API
- 39a5f2a94f8a 13.0 landed
-
pgbench: Use common logging API
- 30a3e772b401 13.0 landed