Re: BUG #16190: The usage of NULL pointer in refint.c

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, starbugs@qq.com, pgsql-bugs@lists.postgresql.org
Date: 2020-01-07T06:44:12Z
Lists: pgsql-bugs
On Mon, Jan 06, 2020 at 06:26:54PM -0800, Andres Freund wrote:
> On 2020-01-06 21:12:05 -0500, Tom Lane wrote:
>> WFM.  There are probably more elegant ways to do it than to drop this
>> stuff into TopMemoryContext, but this is surely better than unchecked
>> malloc calls.
> 
> Yea, it's certainly better than the current situation. An incremental
> improvement would be to do the allocations in a separate contect, for easier
> debugging should there ever be a leak...

Sure.  I am not sure if that's worth the extra work though, so I would
just be tempted to commit the patch that moves the allocation to
TopMemoryContext and call it a day.  Any objections to that?
--
Michael

Commits

  1. Remove dependency to system calls for memory allocation in refint