Re: BUG #16190: The usage of NULL pointer in refint.c

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, starbugs@qq.com, pgsql-bugs@lists.postgresql.org
Date: 2020-01-06T17:44:43Z
Lists: pgsql-bugs
Hi,

On 2020-01-06 01:21:35 -0500, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > ... There could be also an argument to just
> > remove the module per the lack of attention it is getting, though it
> > is still useful as an example of use for SPI, and the docs mention
> > it for that.
> 
> The regression tests use refint too.  Still, it's not production-grade
> code by any means, and I'm not sure if there's much point in making
> it so.  I won't stand in the way if somebody else wants to ;-)

I think we should consider either moving this out of contrib, or fixing
it up. test/example code is fine, but contrib gets installed by default
for a lot of people... And yea, this isn't just about contrib/spi.

Greetings,

Andres Freund



Commits

  1. Remove dependency to system calls for memory allocation in refint