Horton

Re: Why does PostgresNode.pm set such a low value of max_wal_senders?

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers@lists.postgresql.org
Date: 2020-09-30T07:22:52Z
Lists: pgsql-hackers 
On Tue, Sep 29, 2020 at 07:04:22PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> I suggest to remove that line.  max_wal_senders used to default to 0
>> when PostgresNode was touched to have this line in commit 89ac7004dad;
>> the global default was raised in f6d6d2920d2c.
> 
> Hm.  We could do so back to v10 where that came in, and there are no
> src/test/subscription tests before v10, so that should be sufficient.
> Sold.

+1.
--
Michael

Commits

  1. Put back explicit setting of replication values within TAP tests.

  2. Remove obsolete replication settings within TAP tests.

  3. Honor TEMP_CONFIG in TAP suites.

  4. Move some code from RewindTest into PostgresNode