Re: pgindent vs dtrace on macos
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-21T19:08:04Z
Lists: pgsql-hackers
On 2020-Sep-21, Tom Lane wrote:
> Oh wait, I forgot about the fmgrprotos.h discrepancy.
>
> I wrote:
> > It strikes me that a low-cost workaround would be to rename these
> > C functions. There's no law that their C names must match the
> > SQL names.
>
> Here's a proposed patch to fix it that way.
pgtypes_numeric.h still contains
typedef struct
{
int ndigits; /* number of digits in digits[] - can be 0! */
int weight; /* weight of first digit */
int rscale; /* result scale */
int dscale; /* display scale */
int sign; /* NUMERIC_POS, NUMERIC_NEG, or NUMERIC_NAN */
NumericDigit *buf; /* start of alloc'd space for digits[] */
NumericDigit *digits; /* decimal digits */
} numeric;
... isn't this more likely to create a typedef entry than merely a
function name?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Exclude fmgrprotos.h from pgindent processing.
- c4133ec169df 14.0 landed
-
Fix a few more generator scripts to produce pgindent-clean output.
- f859c2ffa01d 14.0 landed
-
Further improve pgindent's list of file exclusions.
- 74d4608f506b 14.0 landed
-
Improve formatting of create_help.pl and plperl_opmask.pl output.
- add105840b67 14.0 landed