Re: Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-09-18T08:22:15Z
Lists: pgsql-hackers
Attachments
- pgtest-fix-range-v3.patch (text/x-diff) patch v3
On Tue, Sep 15, 2020 at 02:39:08PM +0200, Peter Eisentraut wrote: > I didn't mean use strtol() to be able to process larger values, but for the > error checking. atoi() cannot detect any errors other than ERANGE. So if > you are spending effort on making the option value parsing more robust, > relying on atoi() will result in an incomplete solution. Okay, after looking at that, here is v3. This includes range checks as well as errno checks based on strtol(). What do you think? -- Michael
Commits
-
Improve range checks of options for pg_test_fsync and pg_test_timing
- 4d29e6dbd0bb 14.0 landed