Horton

Re: pgindent vs dtrace on macos

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-17T00:03:34Z
Lists: pgsql-hackers 
On 2020-Sep-16, Tom Lane wrote:

> Daniel Gustafsson <daniel@yesql.se> writes:

> > Not sure what pgindent is doing there, but it seems hard to address in the
> > generator.
> 
> I think the issue is that pgindent believes "numeric" and "chr" are
> typedefs.  (The regex code can be blamed for "chr", but I'm not quite
> sure where "numeric" is coming from.)

It's in src/interfaces/ecpg/include/pgtypes_numeric.h

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Exclude fmgrprotos.h from pgindent processing.

  2. Fix a few more generator scripts to produce pgindent-clean output.

  3. Further improve pgindent's list of file exclusions.

  4. Improve formatting of create_help.pl and plperl_opmask.pl output.