Re: Optimising compactify_tuples()

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>, Jakub Wartak <Jakub.Wartak@tomtom.com>, Peter Geoghegan <pg@bowt.ie>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-16T23:05:18Z
Lists: pgsql-hackers
On 2020-09-16 14:01:21 +1200, Thomas Munro wrote:
> On Wed, Sep 16, 2020 at 1:30 PM David Rowley <dgrowleyml@gmail.com> wrote:
> > Thanks a lot for the detailed benchmark results and profiles. That was
> > useful.  I've pushed both patches now. I did a bit of a sweep of the
> > comments on the 0001 patch before pushing it.
> >
> > I also did some further performance tests of something other than
> > recovery. I can also report a good performance improvement in VACUUM.
> > Something around the ~25% reduction mark
> 
> Wonderful results.  It must be rare for a such a localised patch to
> have such a large effect on such common workloads.

Indeed!



Commits

  1. Optimize compactify_tuples function

  2. Report resource usage at the end of recovery

  3. Allow incremental sorts for windowing functions