Horton

Re: Inconsistency in determining the timestamp of the db statfile.

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-09-10T13:12:10Z
Lists: pgsql-hackers 
On 2020-Sep-10, Amit Kapila wrote:

> On Thu, Sep 10, 2020 at 1:03 PM Magnus Hagander <magnus@hagander.net> wrote:

> The comments already say what you said in the second suggestion:"The
> caller must rely on timestamp stored in *ts iff the function returns
> true.". Read iff "as if and only if"

I think "must" should be "may" there, if we're nitpicking.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix inconsistency in determining the timestamp of the db statfile.

  2. Split pgstat file in smaller pieces