Horton

Re: Collation versioning

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>, Douglas Doole <dougdoole@gmail.com>, Christoph Berg <myon@debian.org>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-07T03:17:41Z
Lists: pgsql-hackers 
On Fri, Aug 14, 2020 at 11:02:35AM +0200, Julien Rouhaud wrote:
> On Fri, Aug 14, 2020 at 04:37:46PM +0900, Michael Paquier wrote:
>> +       /*
>> +        * XXX For deterministic transaction, se should only track the
>> version
>> +        * if the AM relies on a stable ordering.
>> +        */
>> +       if (determ_colls)
>> +       {
>> +           /* XXX check if the AM relies on a stable ordering */
>> +           recordDependencyOnCollations(&myself, determ_colls, true);
>> Some cleanup needed here?  Wouldn't it be better to address the issues
>> with stable ordering first?
> 
> Didn't we just agreed 3 mails ago to *not* take care of that in this patch, and
> add an extensible solution for that later?  I kept the XXX comment to make it
> extra clear that this will be addressed.

FWIW, I tend to prefer the approach where we put in place the
necessary infrastructure first, and then have a feature rely on what
we think is the most correct.  This way, we avoid having any moment in
the code history where we have something that we know from the start
is not covered.

The patch set needs a rebase.  There are conflicts coming at least
from pg_depend.c where I switched the code to use multi-INSERTs for
catalog insertions.
--
Michael

Commits

  1. Doc: Document known problem with Windows collation versions.

  2. Add collation versions for FreeBSD.

  3. Tolerate version lookup failure for old style Windows locale names.

  4. Track collation versions for indexes.

  5. Add pg_depend.refobjversion.

  6. Remove pg_collation.collversion.

  7. Fix the MSVC build for versions 2015 and later.

  8. Add collation versions for Windows.

  9. Implement type regcollation

  10. Use libc version as a collation version on glibc systems.

  11. Make type "name" collation-aware.