Horton

Re: [BUG v13] Crash with event trigger in extension

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-bugs@lists.postgresql.org
Date: 2020-09-04T01:20:13Z
Lists: pgsql-bugs 
On Thu, Sep 03, 2020 at 07:41:14PM +0200, Jehan-Guillaume de Rorthais wrote:
> +$node->safe_psql('postgres',
> +	q{CREATE EXTENSION test_event_trigger VERSION '1.0'});
> +$node->safe_psql('postgres',
> +	q{ALTER EXTENSION test_event_trigger UPDATE TO '2.0'});
> +
> +my $ans = $node->safe_psql('postgres', q{
> +	SELECT extversion
> +	FROM pg_catalog.pg_extension
> +	WHERE extname='test_event_trigger'
> +});
> +
> +is($ans, '2.0', 'Extension test_event_trigger upgraded');

I may be missing something of course, but if this just tests a
sequence of SQL commands, why don't you just include a SQL test in
text_extensions/sql/?  That would be much cheaper than having to
create a full scenario with a TAP script.
--
Michael

Commits

  1. Fix use-after-free bug with event triggers and ALTER TABLE.

  2. Fix use-after-free bug with event triggers in an extension script