Horton

Re: REINDEX SCHEMA/DATABASE/SYSTEM weak with dropped relations

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-09-02T00:20:13Z
Lists: pgsql-hackers 
On Tue, Sep 01, 2020 at 01:25:27PM +0300, Anastasia Lubennikova wrote:
> Yes, this version is good.

Thanks.  I have added an extra comment for the case of RELKIND_INDEX
with REINDEXOPT_MISSING_OK while on it, as it was not really obvious
why the parent relation needs to be locked (at least attempted to) at
this stage.  And applied the change.  Thanks for the review,
Anastasia.
--
Michael

Commits

  1. Fix thinko with definition of REINDEXOPT_MISSING_OK

  2. Improve handling of dropped relations for REINDEX DATABASE/SCHEMA/SYSTEM