Re: Switch to multi-inserts for pg_depend

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>
Date: 2020-08-31T07:56:06Z
Lists: pgsql-hackers

Attachments

On Sat, Aug 15, 2020 at 10:50:37AM +0900, Michael Paquier wrote:
> What are you suggesting here?  A new API layer to manage a set of
> slots?

It has been a couple of weeks, and I am not really sure what is the
suggestion here.  So I would like to move on with this patch set as
the changes are straight-forward using the existing routines for
object addresses by grouping all insert dependencies of the same type.
Are there any objections?

Attached is a rebased set, where I have added in indexing.h a unique
definition for the hard limit of 64kB for the amount of data that can
be inserted at once, based on the suggestion from Alvaro and Andres.
--
Michael

Commits

  1. Switch to multi-inserts when registering dependencies for many code paths

  2. Use multi-inserts for pg_depend