Horton

Re: please update ps display for recovery checkpoint

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "k.jamison@fujitsu.com" <k.jamison@fujitsu.com>
Cc: 'Justin Pryzby' <pryzby@telsasoft.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-08-31T06:52:44Z
Lists: pgsql-hackers 
On Thu, Aug 20, 2020 at 05:09:05PM +0900, Michael Paquier wrote:
> That could be helpful.  Wouldn't it be better to use "end-of-recovery
> checkpoint" instead?  That's the common wording in the code comments.
> 
> I don't see the point of patch 0002.  In the same paragraph, we
> already know that this applies to any checkpoints.

Thinking more about this..  Could it be better to just add some calls
to set_ps_display() directly in CreateCheckPoint()?  This way, both
the checkpointer as well as the startup process at the end of recovery
would benefit from the change.
--
Michael

Commits

  1. Provide recovery_init_sync_method=syncfs.

  2. Add some checkpoint/restartpoint status to ps display