Horton

Thread

Commits

  1. Suppress compiler warning in non-cassert builds.

  1. Compiler warning

    Bruce Momjian <bruce@momjian.us> — 2020-08-26T16:02:51Z

    I see a compiler warning on git master:

   sharedfileset.c:288:8: warning: variable ‘found’ set but not used [-Wunused-but-set-variable]

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee

  2. Re: Compiler warning

    Tom Lane <tgl@sss.pgh.pa.us> — 2020-08-26T16:08:48Z

    Bruce Momjian <bruce@momjian.us> writes:
> I see a compiler warning on git master:
>    sharedfileset.c:288:8: warning: variable ‘found’ set but not used [-Wunused-but-set-variable]

Could get rid of the variable entirely: change the "break" to "return"
and then the final Assert can be "Assert(false)".

			regards, tom lane