Horton

Re: some unused parameters cleanup

Bruce Momjian <bruce@momjian.us>

View thread View on postgr.es
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-08-25T17:42:29Z
Lists: pgsql-hackers 
On Tue, Aug 25, 2020 at 12:59:31PM -0400, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > Here is a series of patches to remove some unused function parameters. 
> > In each case, the need for them was removed by some other code changes 
> > over time but the unusedness was not noticed.  I have included a 
> > reference to when they became unused in each case.
> 
> For some of these, there's an argument for keeping the unused parameter
> for consistency with sibling functions that do use it.  Not sure how
> important that is, though.

I think if they are kept for that reason, we should document that so we
know not to revisit this issue for them.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee

Commits

  1. Remove unused parameters

  2. Remove unused parameter

  3. Keep pg_stat_statements' query texts in a file, not in shared memory.