Horton

Thread

Commits

  1. Fixup some misusages of bms_num_members()

  1. Fix a couple of misuages of bms_num_members()

    David Rowley <dgrowleyml@gmail.com> — 2020-08-25T12:51:37Z

    I noticed today there are a few places where we use bms_num_memebers()
where we really should be using bms_membership().  These are not bugs,
they're mostly just bad examples to leave laying around, at best, and
a small performance penalty, at worst.

Unless there are any objections, I plan to push this to master only in
about 10 hours time.

David

  2. Re: Fix a couple of misuages of bms_num_members()

    Tomas Vondra <tomas.vondra@2ndquadrant.com> — 2020-08-25T13:18:02Z

    On Wed, Aug 26, 2020 at 12:51:37AM +1200, David Rowley wrote:
>I noticed today there are a few places where we use bms_num_memebers()
>where we really should be using bms_membership().  These are not bugs,
>they're mostly just bad examples to leave laying around, at best, and
>a small performance penalty, at worst.
>
>Unless there are any objections, I plan to push this to master only in
>about 10 hours time.
>

Seems OK to me. Thanks.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  3. Re: Fix a couple of misuages of bms_num_members()

    David Rowley <dgrowleyml@gmail.com> — 2020-08-25T22:52:49Z

    On Wed, 26 Aug 2020 at 01:18, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:
>
> On Wed, Aug 26, 2020 at 12:51:37AM +1200, David Rowley wrote:
> >I noticed today there are a few places where we use bms_num_memebers()
> >where we really should be using bms_membership().  These are not bugs,
> >they're mostly just bad examples to leave laying around, at best, and
> >a small performance penalty, at worst.
> >
> >Unless there are any objections, I plan to push this to master only in
> >about 10 hours time.
> >
>
> Seems OK to me. Thanks.

Thanks for having a look.  Pushed.

David