Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2020-08-17T18:11:47Z
Lists: pgsql-hackers 
Hi,

On 2020-08-15 13:44:34 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > One thing is that some here are actively against manually adding entries
> > to typedefs.list.
> 
> I've been of the opinion that it's pointless to do so under the current
> regime where (a) only a few people do that and (b) we only officially
> re-indent once a year anyway.  When I want to manually run pgindent,
> I always pull down a fresh typedefs.list from the buildfarm, which is
> reasonably up-to-date regardless of what people added or didn't add,
> and then add any new typedefs from my current patch to that out-of-tree
> copy.

Well, properly indenting new code still is worthwhile. And once you go
through the trouble of adding the typedefs locally, I don't really see
the reason not to also include them in the commit. Sure it'll not help
much with tree-wide re-indents, but with individual files it can still
make life less painful.

Greetings,

Andres Freund

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.