Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2020-08-17T18:05:14Z
Lists: pgsql-hackers 
Hi,

On 2020-08-17 13:54:15 -0400, Bruce Momjian wrote:
> On Sat, Aug 15, 2020 at 01:44:34PM -0400, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > > Without a properly indented baseline that's hard to do, because it'll
> > > cause damage all over. So I don't think we easily can start just there -
> > > we'd first need to re-indent everything.
> > 
> > Well, we can certainly do a tree-wide re-indent anytime we're ready.
> > I doubt it would be very painful right now, with so little new work
> > since the last run.
> 
> Uh, I thought Tom was saying we need to reindent all branches, which
> would be a big change for those tracking forks.

I don't think he said that? He said *if* we were to reindent all
branches, forks would probably have an issue. We're already reindenting
HEAD on a regular basis (just very infrequent), so it can't be a
fundamental issue.

Greetings,

Andres Freund

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.