Horton

Re: walsender waiting_for_ping spuriously set

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: ashutosh.bapat@2ndquadrant.com, Noah Misch <noah@leadboat.com>
Date: 2020-08-07T23:18:29Z
Lists: pgsql-hackers 
On 2020-Aug-07, Alvaro Herrera wrote:

> I'm thinking in keeping the sentences that were added in that commit,
> maybe like so:
> 
> >  		 * We only send regular messages to the client for full decoded
> >  		 * transactions, but a synchronous replication and walsender shutdown
> >  		 * possibly are waiting for a later location. So, before sleeping, we
> > +		 * send a ping containing the flush location. A reply from standby is
> > +		 * not needed and would be wasteful most of the time,
> > +		 * but if the receiver is otherwise idle and walreceiver status messages
> > +		 * are enabled, this keepalive will trigger a reply.  Processing the
> > +		 * reply will update these MyWalSnd locations.

After rereading this a few more times, I think it's OK as Noah had it,
so I'll just use his wording.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. walsnd: Don't set waiting_for_ping_response spuriously

  2. Be less aggressive in asking for feedback of logical walsender clients.