Horton

Re: expose parallel leader in CSV and log_line_prefix

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Julien Rouhaud <rjuju123@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2020-08-01T03:31:13Z
Lists: pgsql-hackers

Attachments

On Fri, Jul 31, 2020 at 03:04:48PM -0500, Justin Pryzby wrote:
> On Tue, Jul 28, 2020 at 10:10:33AM +0900, Michael Paquier wrote:
> > Except for those nits, I have tested the patch and things behave as we
> > want (including padding and docs), so this looks good to me.
> 
> Revised with your suggestions.

Uh, wrong patch.  2nd attempt.

Also, I was reminded by Tom's c410af098 about this comment:

                 * Further note: At least on some platforms, passing %*s rather than
                 * %s to appendStringInfo() is substantially slower, so many of the
                 * cases below avoid doing that unless non-zero padding is in fact
                 * specified.

It seems we can remove that hack and avoid its spiriling conditionals.
It's cleaner to make that 0001.

-- 
Justin

Commits

  1. Add %P to log_line_prefix for parallel group leader

  2. Tweak behavior of pg_stat_activity.leader_pid

  3. Add leader_pid to pg_stat_activity