Horton

Thread

Commits

  1. doc: Mention index references in pg_inherits

  1. Doc patch: mention indexes in pg_inherits docs

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> — 2020-07-28T11:21:29Z

    Hi Hackers,

When partitioned index support was added in veresion 11, the pg_inherits
docs missed the memo and still only say it describes table inheritance.
The attached patch adds mentions of indexes too, and notes that they can
not participate in multiple inheritance.

I don't know what the policy is on backpatching doc fixes, but
personally I think it should be.

- ilmari
-- 
"A disappointingly low fraction of the human race is,
 at any given time, on fire." - Stig Sandbeck Mathisen

  2. Re: Doc patch: mention indexes in pg_inherits docs

    Michael Paquier <michael@paquier.xyz> — 2020-07-29T06:06:58Z

    On Tue, Jul 28, 2020 at 12:21:29PM +0100, Dagfinn Ilmari Mannsåker wrote:
> When partitioned index support was added in veresion 11, the pg_inherits
> docs missed the memo and still only say it describes table inheritance.
> The attached patch adds mentions of indexes too, and notes that they can
> not participate in multiple inheritance.

What you have here looks fine to me.  We could be more picky regarding
the types or relations that can be added, as it can actually be
possible to have a partitioned table or index, two relkinds of their
own, but what you are proposing looks fine enough here.

> I don't know what the policy is on backpatching doc fixes, but
> personally I think it should be.

This is actually a bug fix, because we include in the docs some
incorrect information, so it should be backpatched.  If there are no
objections, I'll take care of that.
--
Michael

  3. Re: Doc patch: mention indexes in pg_inherits docs

    Michael Paquier <michael@paquier.xyz> — 2020-07-30T06:53:48Z

    On Wed, Jul 29, 2020 at 03:06:58PM +0900, Michael Paquier wrote:
> This is actually a bug fix, because we include in the docs some
> incorrect information, so it should be backpatched.  If there are no
> objections, I'll take care of that.

And done.
--
Michael

  4. Re: Doc patch: mention indexes in pg_inherits docs

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> — 2020-07-30T09:56:22Z

    Michael Paquier <michael@paquier.xyz> writes:

> On Wed, Jul 29, 2020 at 03:06:58PM +0900, Michael Paquier wrote:
>> This is actually a bug fix, because we include in the docs some
>> incorrect information, so it should be backpatched.  If there are no
>> objections, I'll take care of that.
>
> And done.

Thanks!

- ilmari
-- 
"A disappointingly low fraction of the human race is,
 at any given time, on fire." - Stig Sandbeck Mathisen