Re: Editing errors in the comments of tableam.h and heapam.c

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Hironobu SUZUKI <hironobu@interdb.jp>

Cc: pgsql-hackers@lists.postgresql.org

Date: 2020-07-13T12:52:12Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix comments related to table AMs
- 330410ecadfb 12.4 landed
- 9678c08184a8 13.0 landed
- 9168793d7275 14.0 landed
tableam: Rename wrapper functions to match callback names.
- 73b8c3bd2889 12.0 cited

On Mon, Jul 13, 2020 at 02:25:39PM +0200, Hironobu SUZUKI wrote:
> Some comments in tableam.h and heapam.c contain three old function names
> although these have been renamed by this commit
> 73b8c3bd2889fed986044e15aefd0911f96ccdd3.
> 
> Old: table_insert, table_fetch_row_version, table_get_latest_tid.
> 
> New: table_tuple_insert, table_tuple_fetch_row_version,
> table_tuple_get_latest_tid.

Thanks.  That looks right.

> I think these are editing errors. PG 12 also has the same errors.

Yeah.  We also recommend to look at tableam.h in the docs, so while
usually I just bother fixing comments on HEAD, it would be better to
back-patch this one.
--
Michael