Re: "tuple concurrently updated" in pg_restore --jobs
Justin Pryzby <pryzby@telsasoft.com>
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Gilman <davidgilman1@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2020-07-10T21:06:07Z
Lists: pgsql-hackers
On Fri, Jul 10, 2020 at 04:54:40PM -0400, Tom Lane wrote: > Justin Pryzby <pryzby@telsasoft.com> writes: > > I hit this issue intermittently (roughly half the time) while working with a > > patch David submitted, and finally found a recipe to reproduce it on an > > unpatched v12 instance. > > > I was surprised to see pg_restore -j2 is restoring ACLs in pre-data in > > parallel. > > It's not pre-data. But it's true that pg_restore figures it can restore > ACLs in parallel during the ACL-restoring pass, on the theory that pg_dump > will not emit two different ACL entries for the same object, so that we > can do all the catalog updates in parallel without conflicts. > > This works about 99% of the time, in fact. It falls down in the --clean Note that this fails for me (sometimes) even without --clean. $ pg_restore pg_dump.out -j2 -d pryzbyj -v --section pre-data pg_restore: entering main parallel loop pg_restore: launching item 3395 ACL TABLE pg_proc pg_restore: launching item 3396 ACL COLUMN pg_proc.proname pg_restore: creating ACL "pg_catalog.TABLE pg_proc" pg_restore: creating ACL "pg_catalog.COLUMN pg_proc.proname" pg_restore: finished item 3395 ACL TABLE pg_proc pg_restore: launching item 3397 ACL COLUMN pg_proc.pronamespace pg_restore: creating ACL "pg_catalog.COLUMN pg_proc.pronamespace" pg_restore: while PROCESSING TOC: pg_restore: from TOC entry 3396; 0 0 ACL COLUMN pg_proc.proname postgres pg_restore: error: could not execute query: ERROR: tuple concurrently updated Command was: GRANT SELECT(proname) ON TABLE pg_catalog.pg_proc TO PUBLIC; -- Justin
Commits
-
Avoid trying to restore table ACLs and per-column ACLs in parallel.
- db820b9a9d00 9.5.23 landed
- 303322c5a4a8 9.6.19 landed
- 2d43c3057c97 10.14 landed
- ea9125304dc6 14.0 landed
- bc9aaac1a188 13.0 landed
- 5fea14f4b2c5 12.4 landed
- 4fdc559c88eb 11.9 landed