Horton

Re: BUG #16526: pg_test_fsync in v12 doesn't run in Windows

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: jeff.janes@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2020-07-10T01:53:54Z
Lists: pgsql-bugs 
On Tue, Jul 07, 2020 at 05:25:49PM +0900, Michael Paquier wrote:
> It seems to me that it would be a better idea to just use the binary
> mode for all the open() calls in pg_test_fsync in the long run, which
> is what the attached patch does as there is no control on the data
> written.  This way, we avoid any translation that may happen during
> the write.  Any thoughts?

I would like to get a second opinion on this one, so for now I have
registered this patch in the CF app:
https://commitfest.postgresql.org/29/2640/
--
Michael

Commits

  1. Switch pg_test_fsync to use binary mode on Windows

  2. Allow concurrent-safe open() and fopen() in frontend code for Windows